Exclude late completions from concurrent QPS - #1185
Closed
fallintoplace wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Count concurrent query outcomes only when the query completes within the configured benchmark window.
Why
Workers currently check the deadline before starting a query, but increment their counters after it finishes regardless of completion time. A query started just before the deadline can finish much later and still be included in
concurrent_qps, which is divided by the original fixed duration.With two workers, a two-second window, and queries that take three seconds, no query completes during the window, but the current code reports
1.000QPS. After this change both late completions are excluded and the result isnull. Workers still finish their in-flight queries normally; this does not introduce client cancellation or leave server-side work behind.Testing
bench_concurrent_qpsprobe: late successes produce null QPSbench_concurrent_qpsprobe: late failures produce null error ratiobench_concurrent_qpsprobe: in-window successes are still countedbash -n lib/benchmark-common.shshellcheck lib/benchmark-common.shgit diff --check